[PATCH] D60094: [MSVC] If unable to find link.exe relative to MSVC, look for link.exe in the path

[Adrian McCarthy via Phabricator via cfe-commits]

amccarth added inline comments.


================
Comment at: lib/Driver/ToolChains/MSVC.cpp:493
       C.getDriver().Diag(clang::diag::warn_drv_msvc_not_found);
+      linkPath = TC.GetProgramPath("link.exe");
+    }
----------------
The comment above explains one reason why we shouldn't use link.exe on the path.

If it is an appropriate fallback, modify the comment or add another one here explaining why this is better than failing.  I think you hit on it in the patch summary, but it should be captured in the code.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60094/new/

https://reviews.llvm.org/D60094