[PATCH] D60046: [python, tests] Disable Clang Python tests on Solaris/SPARC

Rainer Orth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 31 03:14:02 PDT 2019


ro created this revision.
ro added a reviewer: rsmith.
ro added a project: clang.
Herald added subscribers: fedor.sergeev, mgorny, jyknight.

Running `make check-all` fails on Solaris 11/SPARC since the clang python tests FAIL:

  ............................
  ======================================================================
  FAIL: test_extent (tests.cindex.test_location.TestLocation)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "tests/cindex/test_location.py", line 87, in test_extent
      self.assert_location(one.extent.start,line=1,column=1,offset=0)
    File "tests/cindex/test_location.py", line 22, in assert_location
      self.assertEqual(loc.column, column)
  AssertionError: 5 != 1
  
  ======================================================================
  FAIL: test_get_children (tests.cindex.test_cursor.TestCursor)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "tests/cindex/test_cursor.py", line 70, in test_get_children
      self.assertEqual(tu_nodes[0].is_definition(), True)
  AssertionError: False != True
  
  ----------------------------------------------------------------------
  Ran 126 tests in 2.123s
  
  FAILED (failures=2, skipped=6)
  
  Unfortunately, this aborts the rest of `make check-all`, even with `-k`, so this patch
  disables the test as is already done on a couple of other targets.
  
  This allowed the `sparc-sun-solaris2.11` test to finish.


Repository:
  rC Clang

https://reviews.llvm.org/D60046

Files:
  bindings/python/tests/CMakeLists.txt


Index: bindings/python/tests/CMakeLists.txt
===================================================================
--- bindings/python/tests/CMakeLists.txt
+++ bindings/python/tests/CMakeLists.txt
@@ -40,6 +40,11 @@
   set(RUN_PYTHON_TESTS FALSE)
 endif()
 
+# Solaris/SPARC has known test failures.
+if(CMAKE_SYSTEM_NAME MATCHES "SunOS" AND ${LLVM_NATIVE_ARCH} MATCHES "Sparc")
+  set(RUN_PYTHON_TESTS FALSE)
+endif()
+
 if(RUN_PYTHON_TESTS)
     set_property(GLOBAL APPEND PROPERTY
                  LLVM_ADDITIONAL_TEST_TARGETS check-clang-python)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60046.193006.patch
Type: text/x-patch
Size: 548 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190331/055b64e9/attachment-0001.bin>


More information about the cfe-commits mailing list