[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/TokenBuffer.cpp:323
+                                              PP.getLangOpts(), Tokens);
+  auto *CB = CBOwner.get();
+
----------------
ilya-biryukov wrote:
> Eugene.Zelenko wrote:
> > Return type is not obvious. Actually variable is used only one, so it's not necessary.
> - The type is quite obvious from the previous line.
> - We need the variable as we `std::move` the `unique_ptr` in the next line and sill want to access the pointer later.
Lines may be separated in future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59887/new/

https://reviews.llvm.org/D59887