[PATCH] D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced.

Wed Mar 27 06:15:04 PDT 2019

aaron.ballman added a reviewer: alexfh.
aaron.ballman added a subscriber: alexfh.
aaron.ballman added a comment.

> Intended as my first commit to the llvm-project.

Welcome! Thank you for working on this!

In D59859#1444176 <https://reviews.llvm.org/D59859#1444176>, @lebedev.ri wrote:

> Please always upload all patches with full context (`-U99999`)
>  I'm not sure why we want this? What is wrong with simply applying clang-tidy twice?

It doubles the execution time of checking a large project (which may be unacceptably slow), and there's no guarantee that twice will be enough in the general case (one set of fixes may trigger a different check's diagnostics, which may get fixed and trigger another check's diagnostics, etc).

However, it seems like we can run into this sort of interaction in many different checks and in many different ways, and I am not certain that we should try to tackle the maintenance burden of dealing with those interactions ad hoc like this. That said, I'm not certain of a more principled solution either. Adding @alexfh to see if he has put any thought into this area and has ideas.

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59859/new/

https://reviews.llvm.org/D59859