[PATCH] D59628: Add support for __attribute__((objc_class_stub))

Jordan Rose via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 26 15:02:45 PDT 2019


jordan_rose added inline comments.


================
Comment at: lib/CodeGen/CGObjCMac.cpp:7285
 
-    Entry = new llvm::GlobalVariable(CGM.getModule(), ObjCTypes.ClassnfABIPtrTy,
+    Entry = new llvm::GlobalVariable(CGM.getModule(), ClassGV->getType(),
                                      false, llvm::GlobalValue::PrivateLinkage,
----------------
Is there a concern here in the non-stub case if GetClassGlobal no longer produces a ObjCTypes.ClassnfABIPtrTy? (Probably not, but thought I'd check [again].)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59628/new/

https://reviews.llvm.org/D59628





More information about the cfe-commits mailing list