[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 25 18:20:39 PDT 2019


Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:17
 
+using llvm::SmallSet;
+
----------------
It'll be easier to use llvm::SmallSet in using statement.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:136
+
+  Finds cases of `cast<>` used as condition in conditional statements
+  which will assert on failure in Debug builds.
----------------
Please use double, not single `.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59802/new/

https://reviews.llvm.org/D59802





More information about the cfe-commits mailing list