[PATCH] D54978: Move the SMT API to LLVM

[Adrian Prantl via Phabricator via cfe-commits]

aprantl added a comment.

I'm afraid this broke some bots that build with `LLVM_ENABLE_MODULES=1`.

For example:

http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/22411/consoleFull#710926295dd1929ea-7054-4089-b7ef-4624c3781fa4

  Undefined symbols for architecture x86_64:
    "llvm::errs()", referenced from:
        llvm::SMTExpr::dump() const in liblldbDebugserverCommon.a(RNBSocket.cpp.o)
        llvm::SMTSolver::dump() const in liblldbDebugserverCommon.a(RNBSocket.cpp.o)
        llvm::SMTSort::dump() const in liblldbDebugserverCommon.a(RNBSocket.cpp.o)
        llvm::SMTExpr::dump() const in liblldbDebugserverCommon.a(SocketAddress.cpp.o)
        llvm::SMTSolver::dump() const in liblldbDebugserverCommon.a(SocketAddress.cpp.o)
        llvm::SMTSort::dump() const in liblldbDebugserverCommon.a(SocketAddress.cpp.o)

Long story short: You can't have an LLVM_DUMP_METHOD defined inline inside of a module.

One way to fix this would be to move the function body of the various

  LLVM_DUMP_METHOD void dump() const { print(llvm::errs()); }

functions into .cpp files.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54978/new/

https://reviews.llvm.org/D54978