[PATCH] D59682: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc.

Simon Pilgrim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 22 06:22:05 PDT 2019


RKSimon added inline comments.


================
Comment at: lib/Headers/ia32intrin.h:31
 
+static __inline__ int __attribute__((__always_inline__, __nodebug__))
+__bsfd(int __A) {
----------------
Ideally we'd have doxygen comments.


================
Comment at: test/CodeGen/bitscan-builtins.c:24
+// CHECK: @test__bsfd
+// CHECK: %[[call:.*]] = call i32 @llvm.cttz.i32(
+  return __bsfd(X);
----------------
Should we be testing the is_zero_undef flag is true?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59682/new/

https://reviews.llvm.org/D59682





More information about the cfe-commits mailing list