[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 21 14:23:13 PDT 2019


JonasToth added a comment.

> Looks like pointless code duplication that is easily avoidable.

True, but I would prefer the refactoring to be private then (so the template stuff with the boilerplate) and a simple overloading interface dispatching to the templated stuff.
In the end I think the public interface is cleaner, easier to understand and not so easily misused (as the template would accept everything in principle, and SFINAE would be worse).


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59650/new/

https://reviews.llvm.org/D59650





More information about the cfe-commits mailing list