[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 21 12:15:20 PDT 2019


efriedma added inline comments.


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:574
+      if (ArgTy->getElementType()->isFloatingPointTy()) {
+        auto fArgs = F->getFunctionType()->params();
+        Type *Tys[] = {fArgs[0], fArgs[1]};
----------------
This code is weird... you're computing the types in two different ways.  Also, missing a check for F->arg_size() (so we don't crash on invalid IR).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59655/new/

https://reviews.llvm.org/D59655





More information about the cfe-commits mailing list