[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 20 03:15:39 PDT 2019


klimek added a comment.

In D55170#1432929 <https://reviews.llvm.org/D55170#1432929>, @MyDeveloperDay wrote:

> > I don't think risk is what matters - in the end it's about cost, and cost is a very technical reason
>
> I'm really sorry I'm not trying to be difficult its just over the years I keep seeing this being said in reviews? but what is the cost? I assume you don't mean a financial cost? could you define cost as a problem so we can address it? what would it take to make `cost` not an issue?


The cost is financial, as it's developer time, which costs real money to companies. In the end, to support this, people like myself who are doing this as part of their job spend time that they'd otherwise spend to make other things better that might be more important. To make cost not an issue we'd need to change clang-format to make changes like this significantly simpler to review & maintain. I'll add a code comment in a moment, given that this is probably something that we'll allow given it fulfills the criteria we've set ourselves.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55170/new/

https://reviews.llvm.org/D55170





More information about the cfe-commits mailing list