[PATCH] D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 19 14:32:31 PDT 2019


craig.topper added a comment.

In D28213#1435542 <https://reviews.llvm.org/D28213#1435542>, @efriedma wrote:

> It's kind of awkward to use ">=" on a CPU enum, but yes, that's the right idea.


I agree, but we do the same thing on the "__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8" define in X86.cpp.

Applying that diff does cause 3 tests to fail. I'll try to work through that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D28213/new/

https://reviews.llvm.org/D28213





More information about the cfe-commits mailing list