[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 19 12:18:16 PDT 2019


Anastasia added a comment.

In D59492#1434822 <https://reviews.llvm.org/D59492#1434822>, @arsenm wrote:

> In D59492#1434636 <https://reviews.llvm.org/D59492#1434636>, @Anastasia wrote:
>
> > In D59492#1433796 <https://reviews.llvm.org/D59492#1433796>, @arsenm wrote:
> >
> > > Should it be downgraded to a warning about an extension instead of just removing it?
> >
> >
> > What would you suggest to put in a warning message? Clang normally doesn't warn about extensions...
>
>
> Isn't that what -pedantic is for?


Yes, indeed I think it's a better approach now since it's still in the spec...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59492/new/

https://reviews.llvm.org/D59492





More information about the cfe-commits mailing list