[PATCH] D59292: [clang-format] messes up indentation when using JavaScript private fields and methods

Martin Probst via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 19 05:19:39 PDT 2019


mprobst accepted this revision.
mprobst added a comment.
This revision is now accepted and ready to land.

Actually I'll fix the nits.



================
Comment at: clang/docs/ReleaseNotes.rst:174
 
-- ...
+- Add support for correct indenting of private fields and methods in Javascript.
 
----------------
Honestly, I think we don't really do release notes for clang-format. Revert this, or I'll drop it when committing your change.


================
Comment at: clang/lib/Format/FormatToken.h:66
   TYPE(JsTypeOptionalQuestion)                                                 \
+  TYPE(JsPrivateIdentifier)                                                    \
   TYPE(LambdaArrow)                                                            \
----------------
nit: please keep alpha sorted, i.e. before Js[T]


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59292/new/

https://reviews.llvm.org/D59292





More information about the cfe-commits mailing list