[PATCH] D59485: [ASTImporter] Allow adding a import strategy to the ASTImporter

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 19 03:32:27 PDT 2019


balazske added a comment.

Another observation: The `Import` function of the strategy now has no way to return an error. An even better version of it would be to include the possibility of import error (with `ImportError`, or other error type). Or the "PreImport" function could indicate if the Decl is handled by the strategy, and `Import` is called only if yes and `Import` can return an `Expected<Decl *>`. (The PostImport is called for every successfully imported Decl.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59485/new/

https://reviews.llvm.org/D59485





More information about the cfe-commits mailing list