[PATCH] D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 19 02:36:55 PDT 2019


Szelethus added a comment.

In D59457#1433180 <https://reviews.llvm.org/D59457#1433180>, @baloghadamsoftware wrote:

> Please rename the patch. Its name does not really express its content.


Good point, sorry about that.

In D59457#1433816 <https://reviews.llvm.org/D59457#1433816>, @xazax.hun wrote:

> I did not check the patch yet but wanted to point out that we might not want to rush about renaming all the variables until the community decides on the coding guideline, see https://reviews.llvm.org/D59251


I wonder why this wasn't posted on cfe-dev. In any case, most of the variables are capitalized, there still is a consistency argument. Refactoring all the dependent patches would also be a pain in the buttocks for little gain.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59457/new/

https://reviews.llvm.org/D59457





More information about the cfe-commits mailing list