[PATCH] D54978: Move the SMT API to LLVM

Sat Mar 16 11:34:35 PDT 2019

ddcc added a comment.

In D54978#1431935 <https://reviews.llvm.org/D54978#1431935>, @delcypher wrote:

> Would one of you be able to file a bug against Z3 to fix this? I am no longer in a position to contribute to Z3 so I can't do this.

I've opened https://github.com/Z3Prover/z3/issues/2184 .

In D54978#1431936 <https://reviews.llvm.org/D54978#1431936>, @delcypher wrote:

> This output means you built Z3 from source that was not in a git repository. In this case the header file should look the same for both Z3's CMake and Python build systems.

That's strange, I have been building from a git repository.

In D54978#1431430 <https://reviews.llvm.org/D54978#1431430>, @mikhail.ramalho wrote:

> 2. Instead of parsing `Z3_FULL_VERSION`, we can parse `Z3_MAJOR_VERSION`, `Z3_MINOR_VERSION` and `Z3_BUILD_NUMBER` which are also available in the same header.

Since the differences in version string depending on the build system are intended behavior, it seems (2) would be preferable?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54978/new/

https://reviews.llvm.org/D54978