[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

Fri Mar 15 12:22:00 PDT 2019

kadircet added a comment.

In D59302#1431045 <https://reviews.llvm.org/D59302#1431045>, @ilya-biryukov wrote:

> I'll look more closely into the details, but just a high-level question now: why would we want to make this optional and not simply surface these extra diagnostics?

The optional part is rather limiting number of diagnostics that is going to be surfaced. So if you have thousands of errors inside preamble only first 100 of them will appear inside main file by default.
But looking at it again, currently there is no way for user to say "do not limit number of diagnostics" :D They can only change this limit to different values.

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59302/new/

https://reviews.llvm.org/D59302