[PATCH] D59377: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC
Jan Korous via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 15 11:56:28 PDT 2019
jkorous added a comment.
In D59377#1430002 <https://reviews.llvm.org/D59377#1430002>, @dexonsmith wrote:
> ... since I noticed that FileManager ...
This kind of implies that we should move the comment from `FileManager` constructor implementation to the header thus making it an explicit part of the interface contract.
// If the caller doesn't provide a virtual file system, just grab the real
// file system.
Maybe https://reviews.llvm.org/D59388 would be the right place to do it.
CHANGES SINCE LAST ACTION
More information about the cfe-commits