[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 14 05:30:55 PDT 2019


probinson added a comment.

I'd preserve the trivial test cases and show that the NonTrivial flag is *not* present.  I can suggest ways to achieve this if you like (note there is no CHECK-DAG-NOT combined directive).



================
Comment at: test/CodeGenCXX/debug-info-composite-triviality.cpp:88
-
-// CHECK-DAG: !DICompositeType({{.*}}, name: "NonTrivialE",{{.*}}flags: {{.*}}DIFlagNonTrivial
-struct NonTrivialE : Trivial, NonTrivial {
----------------
This one used to be flagged nontrivial, and now it's not flagged?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59347/new/

https://reviews.llvm.org/D59347





More information about the cfe-commits mailing list