[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 14 02:57:27 PDT 2019


MyDeveloperDay added a comment.

In D59309#1428799 <https://reviews.llvm.org/D59309#1428799>, @klimek wrote:

> Why did the numeric constant break this? Which path would the function run through?


as its looking though the parameter list is doesn't recognize a numeric constant as being a valid thing it would see in an argument list and so falls through the bottom to return false, it will only be where there is a numeric_constant as the first argument, if it has a second argument and that argument is just a simple type it would still fail, but switch them around and it won't

As I look more at this, even this would fail to break

  int TestFn(A=1)
  {
    return a;
  }




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59309/new/

https://reviews.llvm.org/D59309





More information about the cfe-commits mailing list