[PATCH] D55044: [clang-tidy] check for Abseil make_unique

Andy Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 13 19:57:28 PDT 2019


axzhang updated this revision to Diff 190559.
axzhang added a comment.

Apologies for the extended hiatus. I have changed the implementation to an alias to modernize-make-unique, and have added an extra option to modernize-make-unique that ignores C++11 features such as list initializations, to allow `absl::make_unique` to function correctly. Also, after looking more into `absl::WrapUnique`, it seems like this also is not really the function to use for brace initializations, so no extra functionality needs to be added to the existing modernize-make-unique check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55044/new/

https://reviews.llvm.org/D55044

Files:
  clang-tidy/abseil/AbseilTidyModule.cpp
  clang-tidy/modernize/MakeSmartPtrCheck.cpp
  clang-tidy/modernize/MakeSmartPtrCheck.h
  docs/ReleaseNotes.rst
  docs/clang-tidy/checks/abseil-make-unique.rst
  docs/clang-tidy/checks/list.rst
  docs/clang-tidy/checks/modernize-make-unique.rst
  test/clang-tidy/abseil-make-unique.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55044.190559.patch
Type: text/x-patch
Size: 10052 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190314/9ac2e11c/attachment.bin>


More information about the cfe-commits mailing list