[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

Stephane Moore via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 13 17:05:22 PDT 2019


stephanemoore marked 2 inline comments as done.
stephanemoore added a comment.

Thanks for the review!



================
Comment at: clang-tools-extra/clang-tidy/google/IntegerTypesCheck.cpp:57
   // Find all TypeLocs. The relevant Style Guide rule only applies to C++.
-  if (!getLangOpts().CPlusPlus)
+  // This check is also not applied in Objective-C++ sources as Objective-C
+  // often uses built-in integer types other than `int`.
----------------
gribozavr wrote:
> gribozavr wrote:
> > "Objective-C and Objective-C++"?  Similarly in release notes.
> I see -- should have read the previous sentence, which you are not changing.  Never mind.
Yup, the previous sentence indicates that the check targets C++ and this added sentence indicates that Objective-C++ is considered an exception.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59336/new/

https://reviews.llvm.org/D59336





More information about the cfe-commits mailing list