[PATCH] D59234: [CodeGen][ObjC] Remove the leading 'l' from symbols for protocol metadata and protocol list

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 12 13:18:35 PDT 2019


rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

Using internal linkage instead of private makes sense to me.  Even if we wanted to use private linkage, it never made sense to be doing this with `\01l` instead of just setting the linkage properly.  Maybe this was implemented before LLVM directly supported private linkage, but that hasn't been a constraint in 10+ years.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59234/new/

https://reviews.llvm.org/D59234





More information about the cfe-commits mailing list