[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 12 08:50:22 PDT 2019

kadircet added inline comments.

Comment at: clang-tools-extra/unittests/clangd/XRefsTests.cpp:1496
+TEST(FindRecordTypeAt, TypeOrVariable) {
+  Annotations Source(R"cpp(
Sorry for not pointing this out before, but it would be great if you could move related tests into a new file, XRefsTests is getting out of hand.

Feel free to ignore if you don't feel like it.

Comment at: clang-tools-extra/unittests/clangd/XRefsTests.cpp:1834
+TEST(TypeHierarchy, RecursiveHierarchy1) {
+  Annotations Source(R"cpp(
Could you also check for the response, since parent traversal for these cases are also disabled currently(due to dependent types issue).
So that we won't forget to fix any issues regarding these cases. 
I suppose, a check with only current symbol and empty parents and children should be enough. Same for other two cases.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list