[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present
Reuben Thomas via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 11 13:42:44 PDT 2019
reuk added a comment.
The code looks good now. There's just a few places left where the formatting looks a bit suspect (sorry for missing those last time). I think once that's fixed this will be good to go.
Comment at: clang/unittests/Format/FormatTest.cpp:553
- AllowSimpleBracedStatements.AllowShortIfStatementsOnASingleLine = true;
+ AllowSimpleBracedStatements.AllowShortIfStatementsOnASingleLine = FormatStyle::SIS_WithoutElse;
AllowSimpleBracedStatements.AllowShortLoopsOnASingleLine = true;
This line, along with some of the following changed lines, have more than 80 characters. Make sure to clang-format changes! Consider using `git-clang-format` to format just this patch.
CHANGES SINCE LAST ACTION
More information about the cfe-commits