[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

Csaba Dabis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 8 16:10:52 PST 2019


Charusso added a comment.

In D58367#1423451 <https://reviews.llvm.org/D58367#1423451>, @NoQ wrote:

> Found a bug! The lambda has to manually make sure that the bug report actually does have something to do with the checker.


I think message-semantic is better than storing some data in two places. BugReport has `getCheckName()` and may if the `NoteTag` knows the name of its author then it is comparable.
I am not sure but may you could hack the lifetime of that `StringRef` from `CheckName` to not to report on something purged out (/not exists?).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58367/new/

https://reviews.llvm.org/D58367





More information about the cfe-commits mailing list