[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 7 05:15:31 PST 2019


gribozavr accepted this revision.
gribozavr added a comment.

Do we also need to change anything for constructor calls?  If not, please add a test for that.



================
Comment at: lib/Index/IndexDecl.cpp:251
+                               Ctor->getParent(), Ctor->getDeclContext(),
+                               (unsigned)(SymbolRole::NameReference));
 
----------------
No need for parens around `SymbolRole::NameReference`.


================
Comment at: lib/Index/IndexDecl.cpp:268
+                                 Dtor->getParent(), Dtor->getDeclContext(),
+                                 (unsigned)(SymbolRole::NameReference));
       }
----------------
No need for parens around `SymbolRole::NameReference`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58814/new/

https://reviews.llvm.org/D58814





More information about the cfe-commits mailing list