[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 7 05:07:30 PST 2019


kadircet marked an inline comment as done.
kadircet added inline comments.


================
Comment at: clangd/GlobalCompilationDatabase.h:116
+  /// Adjusts given compile command for clangd.
+  tooling::CompileCommand adjustArguments(tooling::CompileCommand Cmd) const;
+
----------------
hokein wrote:
> ioeric wrote:
> > This doesn't seem to be used in this patch (except for tests). Could you include intended uses in the patch so we can understand the problem better?
> Looks like this patch introduces two changes:
> 
> - move the internal adjustArguments to public, I have the same question, any reason doing it? because we can test it? 
> - add additional Adjusters to adjustArguments
It was only for testing


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59086/new/

https://reviews.llvm.org/D59086





More information about the cfe-commits mailing list