[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 5 10:48:54 PST 2019


Anastasia added a comment.

In D58346#1417983 <https://reviews.llvm.org/D58346#1417983>, @rjmccall wrote:

> In the abstract, it would be nice to warn about casts that always have UB because the address spaces don't overlap; however, I'm worried about how people might be using address spaces in strange ways today, knowing that they *do* overlap, only in ways that the compiler isn't smart enough for.  I think we should just be permissive in non-OpenCL mode.


Ok, I have explained this in FIXME.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58346/new/

https://reviews.llvm.org/D58346





More information about the cfe-commits mailing list