[PATCH] D58917: [HIP] Do not unbundle object files for -fno-gpu-rdc

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 4 12:01:04 PST 2019


yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added a subscriber: jdoerfert.
Herald added a project: clang.

When -fno-gpu-rdc is set, device code is compiled, linked, and assembled into fat binary
and embedded as string in object files. The object files are normal object files which
can be linked by host linker. In the linking stage, the object files should not be unbundled
when -fno-gpu-rdc is set since they are normal object files, not bundles. The object files
only need to be unbundled when -fgpu-rdc is set.

Currently clang always unbundles object files, disregarding -fgpu-rdc option.

This patch fixes that.


Repository:
  rC Clang

https://reviews.llvm.org/D58917

Files:
  lib/Driver/Driver.cpp
  test/Driver/hip-binding.hip
  test/Driver/hip-link-shared-library.hip

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58917.189179.patch
Type: text/x-patch
Size: 4574 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190304/d7eea7da/attachment.bin>


More information about the cfe-commits mailing list