[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec
Aleksei Sidorin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Mar 3 11:00:31 PST 2019
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Thanks for the patch! It looks good to me except some stylish nits.
Comment at: lib/AST/ASTImporter.cpp:5130
+ Importer.MapImported(D, PrevDecl->getDefinition());
+ // Import those those default field initializers which have been
+ // instantiated in the "From" context, but not in the "To" context.
Could you please also replace "those those" to "those" in the comment below?
Comment at: lib/AST/ASTImporter.cpp:5144
+ // Generally, ASTCommon.h/DeclUpdateKind enum gives a very good hint
+ // what
+ // else could be fused during an AST merge.
The comment is a bit broken.
CHANGES SINCE LAST ACTION
More information about the cfe-commits