[PATCH] D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)
Bill Wendling via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 1 11:25:17 PST 2019
void added a comment.
My opinion doesn't carry as much weight as others who are more familiar with the front-end code, but LGTM.
One question, the code you added looks similar. Is there a way to extrapolate it into its own function? Maybe yet another `EvaluateAs*` method?
Comment at: clang/lib/Sema/SemaStmtAsm.cpp:389
+ // For compatibility with GCC, we also allows pointers that would be
+ // integral constant expressions if they were cast to int.
CHANGES SINCE LAST ACTION
More information about the cfe-commits