[PATCH] D58807: [CodeGen] COMDAT-fold block descriptors

David Chisnall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 1 00:34:49 PST 2019


theraven accepted this revision.
theraven added a comment.
This revision is now accepted and ready to land.

Looks good to me.  On ELF and Mach-O, I think we get the equivalent behaviour automatically from the ODR linkage type.  I'd really like to see linkage type and COMDAT made orthogonal, but that's a bigger change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58807/new/

https://reviews.llvm.org/D58807





More information about the cfe-commits mailing list