[PATCH] D58091: Customize warnings for missing built-in type

Brian Cain via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 28 14:42:56 PST 2019

bcain added a comment.

In D58091#1409584 <https://reviews.llvm.org/D58091#1409584>, @jdoerfert wrote:

> I did address the comments but I will wait until I hear back on the "warning vs warning + note question".


> I do not have strong feelings about this, either way is fine with me. However, I lack the 
>  clang expertise to make such a change happen anytime soon which makes this patch
>  (with actual fix for the warning on pthread_create) my prefered first step.

FWIW, I'm satisfied with the fix as proposed here for now and I wouldn't be opposed to following up with an improvement over other warnings in lieu of this warning.

@jyknight -- James, (or others) care to weigh in on this proposal?

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list