[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

Thomas Lively via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 28 10:38:24 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rLLD355112: [WebAssembly] Remove uses of ThreadModel (authored by tlively, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D58742?vs=188634&id=188758#toc

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58742/new/

https://reviews.llvm.org/D58742

Files:
  test/wasm/init-fini.ll
  test/wasm/lto/atomics.ll
  wasm/LTO.cpp


Index: test/wasm/init-fini.ll
===================================================================
--- test/wasm/init-fini.ll
+++ test/wasm/init-fini.ll
@@ -1,5 +1,5 @@
-; RUN: llc -filetype=obj -thread-model=single -o %t.o %s
-; RUN: llc -filetype=obj -thread-model=single %S/Inputs/global-ctor-dtor.ll -o %t.global-ctor-dtor.o
+; RUN: llc -filetype=obj -o %t.o %s
+; RUN: llc -filetype=obj %S/Inputs/global-ctor-dtor.ll -o %t.global-ctor-dtor.o
 
 target triple = "wasm32-unknown-unknown"
 
Index: test/wasm/lto/atomics.ll
===================================================================
--- test/wasm/lto/atomics.ll
+++ test/wasm/lto/atomics.ll
@@ -1,7 +1,8 @@
 ; RUN: llvm-as %s -o %t.o
 ; RUN: wasm-ld %t.o -o %t.wasm -lto-O0
-; Atomic operations with fail to compile if the ThreadModel is not
-; correctly set to Single (i.e. if atomics are not lowered to regular ops).
+
+; Atomic operations will not fail to compile if atomics are not
+; enabled because LLVM atomics will be lowered to regular ops.
 
 target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
 target triple = "wasm32-unknown-unknown-wasm"
Index: wasm/LTO.cpp
===================================================================
--- wasm/LTO.cpp
+++ wasm/LTO.cpp
@@ -47,9 +47,6 @@
   C.Options.FunctionSections = true;
   C.Options.DataSections = true;
 
-  // Wasm currently only supports ThreadModel::Single
-  C.Options.ThreadModel = ThreadModel::Single;
-
   C.DisableVerify = Config->DisableVerify;
   C.DiagHandler = diagnosticHandler;
   C.OptLevel = Config->LTOO;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58742.188758.patch
Type: text/x-patch
Size: 1545 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190228/81030a11/attachment-0001.bin>


More information about the cfe-commits mailing list