[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 27 12:42:27 PST 2019
MyDeveloperDay added a comment.
In D28462#1407239 <https://reviews.llvm.org/D28462#1407239>, @micah-s wrote:
> ClamAV recently started using clang-format. We published this blog post about how we're using it: https://blog.clamav.net/2019/02/clamav-adopts-clang-format.html One of the things I called out in the blog post is that we really want this feature, and presently we have to use the "// clang-format on/off" markers throughout our code mostly to keep our consecutive macros aligned.
> I haven't found time to build clang-format with this patch to test it on our code base with the markers disabled. If a review of my experience doing so will help get traction for this review in any way, let me know and I'll make the effort.
For those wishing to test the effectiveness of unlanded revisions like this and to reduce the amount of time between Windows snapshot builds (https://llvm.org/builds/), I have forked llvm-project and using AppVeyor to build a new x64 Windows clang-format-experimental.exe binary, on a semi-automatic basis. (master branch clang-format with selected unlanded revisions)
When a revision like this meets excessive delay in the review cycle, feel free to log a github issue, Early testing of unlanded features may help to prove the usefulness of a revision, provide useful review comments and/or help find bugs earlier in the development cycle.
CHANGES SINCE LAST ACTION
More information about the cfe-commits