[clang-tools-extra] r354903 - [clang-tidy] undo bitfields in ExceptionAnalyzer

Jonas Toth via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 26 10:15:18 PST 2019

Author: jonastoth
Date: Tue Feb 26 10:15:17 2019
New Revision: 354903

URL: http://llvm.org/viewvc/llvm-project?rev=354903&view=rev
[clang-tidy] undo bitfields in ExceptionAnalyzer

Scoped enums do induce some problems with some MSVC and GCC versions
if used as bitfields. Therefor this is deactivated for now.


Modified: clang-tools-extra/trunk/clang-tidy/utils/ExceptionAnalyzer.h
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/utils/ExceptionAnalyzer.h?rev=354903&r1=354902&r2=354903&view=diff
--- clang-tools-extra/trunk/clang-tidy/utils/ExceptionAnalyzer.h (original)
+++ clang-tools-extra/trunk/clang-tidy/utils/ExceptionAnalyzer.h Tue Feb 26 10:15:17 2019
@@ -109,19 +109,17 @@ public:
     /// Keep track if the entity related to this 'ExceptionInfo' can in princple
     /// throw, if it's unknown or if it won't throw.
-    State Behaviour : 2;
+    State Behaviour;
     /// Keep track if the entity contains any unknown elements to keep track
     /// of the certainty of decisions and/or correct 'Behaviour' transition
     /// after filtering.
-    bool ContainsUnknown : 1;
+    bool ContainsUnknown;
     /// 'ThrownException' is empty if the 'Behaviour' is either 'NotThrowing' or
     /// 'Unknown'.
     Throwables ThrownExceptions;
-  static_assert(sizeof(ExceptionInfo) <= 64u,
-                "size of exceptioninfo shall be at max one cache line");
   ExceptionAnalyzer() = default;

More information about the cfe-commits mailing list