[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 26 07:04:11 PST 2019


MyDeveloperDay added inline comments.
Herald added a subscriber: jdoerfert.


================
Comment at: clang/lib/Format/ContinuationIndenter.cpp:193
                               RawStringFormat.Language, &PredefinedStyle)) {
-        PredefinedStyle = getLLVMStyle();
+        PredefinedStyle = getLLVMStyle(FormatStyle::LK_Cpp);
         PredefinedStyle.Language = RawStringFormat.Language;
----------------
if you've set up a default argument of LK_Cpp do you need to keep supplying it? if your going to supply it everywhere don't make it a default argument or vice versa

This might make a much smaller patch, a little more digestable and all the tests can remain as they are.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56943/new/

https://reviews.llvm.org/D56943





More information about the cfe-commits mailing list