[PATCH] D58448: [clangd] Improve global code completion when scope specifier is unresolved.

Ilya Biryukov via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 26 02:20:05 PST 2019

Slightly offtopic.

It would be nice to add a way to collect quality during actual completion
sessions, rather than simulated ones.
I'm thinking about clients sending a message to the server mentioning the
completion item user ended up selecting in a completion list (would require
an LSP extension).
I believe this should be enough information to collect metrics for the use
of code completion in the wild.

On Tue, Feb 26, 2019 at 11:04 AM Eric Liu <ioeric at google.com> wrote:

> Unfortunately, the evaluation tool I use only works on compilable code, so
> it doesn't capture the unsolved specifier case in this patch. I didn't try
> to collect the metrics because I think this is more of a bug fix than
> quality improvement.
> On Tue, Feb 26, 2019, 10:25 Kadir Cetinkaya via Phabricator <
> reviews at reviews.llvm.org> wrote:
>> kadircet added a comment.
>> LG
>> Do we have any metrics regarding change in completion quality?
>> Repository:
>>   rCTE Clang Tools Extra
>>   https://reviews.llvm.org/D58448/new/
>> https://reviews.llvm.org/D58448

Ilya Biryukov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190226/02d13c54/attachment.html>

More information about the cfe-commits mailing list