[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

Bruno Ricci via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 22 04:22:44 PST 2019


riccibruno added inline comments.


================
Comment at: include/clang/Basic/Sanitizers.h:173
+      SanitizerMask::bitPosToMask(SO_##ID##Group);                             \
+  static const SanitizerMask &ID##Group = SanitizerMasks<>::ID##Group;
 #include "clang/Basic/Sanitizers.def"
----------------
pgousseau wrote:
> riccibruno wrote:
> > You are back to the same issue with the references.
> A yes I should have read the odr definition more carefully! I am trying to find a way to not have to add `SanitizerMasks<>::` all over the place, any ideas?
Nope, unfortunately.

(And I am wondering how many other similar issues exist in clang/llvm; I would bet it is > 0).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57914/new/

https://reviews.llvm.org/D57914





More information about the cfe-commits mailing list