[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 21 02:13:41 PST 2019


kadircet created this revision.
kadircet added reviewers: ilya-biryukov, sammccall.
Herald added subscribers: cfe-commits, arphaman, mgrang, jkorous, MaskRay, ioeric.
Herald added a project: clang.

Clangd was reporting implicit symbols, like results of implicit cast
expressions during code navigation, which is not desired. For example:

  struct Foo{ Foo(int); };
  void bar(Foo);
  vod foo() {
    int x;
    bar(^x);
  }

Performing a GoTo on the point specified by ^ would give two results one
pointing to line `int x` and the other for definition of `Foo(int);`


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D58495

Files:
  clangd/XRefs.cpp
  unittests/clangd/SymbolInfoTests.cpp
  unittests/clangd/XRefsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58495.187744.patch
Type: text/x-patch
Size: 7847 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190221/3ab526bc/attachment.bin>


More information about the cfe-commits mailing list