[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 18 01:08:26 PST 2019


MyDeveloperDay added a comment.

In D57087#1400578 <https://reviews.llvm.org/D57087#1400578>, @malcolm.parsons wrote:

> Some Clang warnings use PP.getLastMacroWithSpelling() to determine the user's macro automatically.


This would be a neat trick, but mainly I think users would either be using override/final or they would know what they were using say OVERRIDE/FINAL because it might be set by a convention for a code base, so maybe its better if they are explicit in their tidy options


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57087/new/

https://reviews.llvm.org/D57087





More information about the cfe-commits mailing list