[PATCH] D58189: [clang][Index] Fix usage of IndexImplicitInstantiation

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 15 05:25:05 PST 2019


kadircet added inline comments.


================
Comment at: unittests/Index/IndexTests.cpp:40
+    Position P;
+    P.Line = static_cast<int>(SM.getLineNumber(FID, Offset)) - 1;
+    P.Column = SM.getColumnNumber(FID, Offset) - 1;
----------------
ilya-biryukov wrote:
> Why do we need to `static_cast` to int? Can we leave out the cast?
it was left over of a copy paste, we don't even need subtraction.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58189/new/

https://reviews.llvm.org/D58189





More information about the cfe-commits mailing list