[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 13 20:20:51 PST 2019


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Awesome, thanks.



================
Comment at: clang/test/Lexer/keywords_test.cpp:57
+#else
+// MS compiler recognizes static_assert in all modes. So should we.
+IS_KEYWORD(static_assert);
----------------
Should this comment (or a comment elsewhere) mention the plan that we want asked for the change to msvc's assert.h and that we want to stop defining this if _MSC_VER is new enough to have that change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D17444/new/

https://reviews.llvm.org/D17444





More information about the cfe-commits mailing list