[PATCH] D58178: [clang-tidy] RawStringLiteralCheck: isRawStringLiteral doesn't check all erroneous cases

Goran Mitrovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 13 10:27:03 PST 2019


gmit added a comment.

In D58178#1396523 <https://reviews.llvm.org/D58178#1396523>, @MyDeveloperDay wrote:

> I tried to repoduce this and I can't see how I could make a string literal without a double quote, if it still failed with the current code it might suggest the matcher matched something else.. understanding what that is is probably more important, than just masking the failure.


I agree to that. There is not obvious reason why this would happen.

> there was a crash D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check <https://reviews.llvm.org/D19331> which was fixed back in April, are you able to tell us the version/revision of clang-tidy where this occurred

The crash happened on Clang 5 and I can confirm fix 19331 was present in the source files that built it.

> It's quite easy to trim down the source that crashes down to something usable with https://embed.cs.utah.edu/creduce/
>  The end result won't resemble anything the original code was, no proprietary secrets will be leaked.
>  Without test case, there is nothing do to here.

No, it's not that - I simply don't have it. I don't have .dmp either. I only have our fix that was done in our local Clang repository copy two years ago and a call stack.

Anyhow, I agree to dismiss this case. Sorry for wasting your time! Thanks!


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58178/new/

https://reviews.llvm.org/D58178





More information about the cfe-commits mailing list