[PATCH] D58178: [clang-tidy] RawStringLiteralCheck: isRawStringLiteral doesn't check all erroneous cases

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 13 08:21:27 PST 2019


lebedev.ri added a comment.

In D58178#1396388 <https://reviews.llvm.org/D58178#1396388>, @gmit wrote:

> The added condition should be obvious as it is tested in the assert just above.


Well, then the fix is not correct. Because you won't get to that `return`,
since the `assert()` just above would have failed already..
This really needs a test.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58178/new/

https://reviews.llvm.org/D58178





More information about the cfe-commits mailing list