[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 12 11:41:29 PST 2019


bruno added a comment.

I missed that the `DependencyCollector` already marks them virtual, you are just making it obvious here.  I think you can omit the ones that are already virtual and only add to the ones that are on the intend of this patch.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58072/new/

https://reviews.llvm.org/D58072





More information about the cfe-commits mailing list