[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

Jonas Devlieghere via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 11 19:09:09 PST 2019


JDevlieghere added a comment.

In D58072#1393817 <https://reviews.llvm.org/D58072#1393817>, @bruno wrote:

> Not really. Would making only the `attachTo*` methods virtual enough though?


You mean making them **not** virtual? They're the only ones I don't override.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58072/new/

https://reviews.llvm.org/D58072





More information about the cfe-commits mailing list