[PATCH] D58089: Add missing library dependencies in CMakeLists.txt

Nicholas Allegra via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 11 16:43:05 PST 2019


comex created this revision.
comex added reviewers: jkorous, phosek.
Herald added subscribers: cfe-commits, kadircet, arphaman, ioeric, ilya-biryukov, mgorny.
Herald added a project: clang.

Fixes build in BUILD_SHARED_LIBS mode.

Removes the "DEPENDS clangdXpcJsonConversions" line as LINK_LIBS already implies a dependency AFAIK.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D58089

Files:
  clang-tools-extra/clangd/xpc/CMakeLists.txt


Index: clang-tools-extra/clangd/xpc/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/xpc/CMakeLists.txt
+++ clang-tools-extra/clangd/xpc/CMakeLists.txt
@@ -20,10 +20,10 @@
 
 add_clang_library(clangdXpcJsonConversions
   Conversion.cpp
+  LINK_LIBS clangDaemon
   )
 
 add_clang_library(clangdXpcTransport
   XPCTransport.cpp
-  DEPENDS clangdXpcJsonConversions
-  LINK_LIBS clangdXpcJsonConversions
+  LINK_LIBS clangDaemon clangdXpcJsonConversions
   )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58089.186369.patch
Type: text/x-patch
Size: 518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190212/eb2aae2d/attachment.bin>


More information about the cfe-commits mailing list